Add address space support and tests for overlap errors - #1602
Open
bratpiorka wants to merge 6 commits into
Open
Conversation
bratpiorka
force-pushed
the
rrudnick_tracking_overlap_fix
branch
14 times, most recently
from
August 27, 2026 10:01
0bee7cf to
48f8058
Compare
bratpiorka
force-pushed
the
rrudnick_tracking_overlap_fix
branch
2 times, most recently
from
September 1, 2026 07:40
800c5a9 to
c21c5e7
Compare
bratpiorka
marked this pull request as ready for review
September 2, 2026 08:28
Contributor
Author
|
@oneapi-src/unified-memory-framework-maintain nightly run passes: https://github.com/oneapi-src/unified-memory-framework/actions/runs/33483230439?pr=1602 |
ldorau
reviewed
Sep 3, 2026
ldorau
left a comment
ldorau
left a comment
Contributor
There was a problem hiding this comment.
I will continue this review on Monday ...
Comment on lines
-42
to
-44
| // Multilevel maps are needed to support the case | ||
| // when one memory pool acts as a memory provider | ||
| // for another memory pool (nested memory pooling). |
Contributor
There was a problem hiding this comment.
I would leave this comment, it can be useful.
Comment on lines
+1125
to
+1126
| for (tracker_address_space_t *address_space = hTracker->address_spaces; | ||
| address_space; address_space = address_space->next) { |
Contributor
There was a problem hiding this comment.
Shouldn't utils_atomic_load_acquire_ptr be used here to set address_space ?
Comment on lines
+1722
to
+1723
| for (tracker_address_space_t *address_space = TRACKER->address_spaces; | ||
| address_space; address_space = address_space->next) { |
Contributor
There was a problem hiding this comment.
Shouldn't utils_atomic_load_acquire_ptr be used here to set address_space ?
kswiecicki
reviewed
Sep 3, 2026
| address-space namespace, and different tokens for independent namespaces. The | ||
| token must remain at a stable address for as long as any provider using it | ||
| exists. Other implementations can use the address of a private static object, | ||
| for example:: |
Contributor
There was a problem hiding this comment.
nit: you've doubled : sign.
| ze_memory_provider_t *ze_provider = provider; | ||
| if (ze_provider->memory_type == ZE_MEMORY_TYPE_HOST) { | ||
| address_space->namespace_token = NULL; | ||
| address_space->context = 0; |
Contributor
There was a problem hiding this comment.
nit: L0 host alloc functions take a context param.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new functionality for identifying and working with process-local address spaces in memory providers, updates the UMF versioning, and improves error handling for ambiguous memory deallocations. The changes primarily add support for querying and specifying address space identities, update provider operation interfaces, and implement the new logic in several memory providers.
Key changes include:
Address Space Identity Support
umf_memory_provider_address_space_tstruct to represent process-local address space identities, and added theUMF_ADDRESS_SPACE_NAMESPACE_HOSTtoken for host address spaces.umfMemoryProviderGetAddressSpaceAPI and corresponding provider operation to retrieve a provider's address space identity. Default and provider-specific implementations were added for CUDA, devdax, file, and fixed memory providers.Provider Interface and Versioning Updates
get_address_spaceoperation in the provider ops initialization logic.Fixed Memory Provider Enhancements
umfFixedMemoryProviderParamsSetAddressSpace) and ensured the address space is initialized and propagated correctly.Ambiguous Free Error Handling
UMF_RESULT_ERROR_AMBIGUOUSand updatedumfFreeto detect and report ambiguous frees when multiple allocations match a pointer, improving safety and diagnostics.